Revert PR #459: ExecuteDFS (generic depth first search)#504
Merged
wilfwilson merged 2 commits intodigraphs:masterfrom Oct 27, 2021
Merged
Revert PR #459: ExecuteDFS (generic depth first search)#504wilfwilson merged 2 commits intodigraphs:masterfrom
ExecuteDFS (generic depth first search)#504wilfwilson merged 2 commits intodigraphs:masterfrom
Conversation
In particular, this pretty much reverses commit: d9f060c
This was referenced Oct 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code introduced in PR #459 was buggy (see #487), and is therefore blocking a release from the
masterbranch, which contains a lot of other good stuff that should be out in the wild.Once this PR is merged, to revert #459, then I will push another branch that reverts the main commit of this PR (which won't be merged as-is), and then rebase #499 on top of that (which will hopefully be completed and merged in the not-too-distant future).